Swift 5.10 #74
Swift 5.10 #74
Conversation
|
|
||
| jobs: | ||
| validation: | ||
| name: Validation | ||
| runs-on: macos-13 | ||
| runs-on: macos-14 |
There was a problem hiding this comment.
@rasberik
Can you update for Test on macOS job as well?
There was a problem hiding this comment.
Ahhh Im making same mistakes everywhere. Thanks, updated
|
@rasberik |
|
@ra1028 Do you think its ok to bump all the way 5 major versions? -"percy": "0.28.4"
+"percy": "5.0.0" |
package.json
Outdated
| @@ -3,6 +3,6 @@ | |||
| "version": "0.1.0", | |||
| "author": "Playbook", | |||
| "devDependencies": { | |||
| "percy": "0.28.4" | |||
| "percy": "5.0.0" | |||
There was a problem hiding this comment.
5 major version bump~
There was a problem hiding this comment.
Lockfile got shrinked massively tho~
There was a problem hiding this comment.
Apparently, that because of this reason.
It seems that the package got renamed to @percy/cli.
There was a problem hiding this comment.
I switched to @percy/cli-upload (pkg) to minimize deps, can we give it a try? Doesnt look like we need config update
There was a problem hiding this comment.
Error still wants percy 5.0.. hmmmhmhmh what did I miss
There was a problem hiding this comment.
Ah, cli is yappari requirement, fixed, please rerun 🙇🏻
Checklist
Why
Maintenance & deps update
Note
Im noticing some performance issues when building with Xcode 16.1.
Screenshots